Process ANSWER-style defaults in apply_composite_tag #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharth-krishna
approved these changes
Mar 24, 2024
xl2times/utils.py
Outdated
| defaults = defaults.split(",") | ||
| else: | ||
| # Make it a list | ||
| defaults = list([defaults]) |
There was a problem hiding this comment.
Suggested change
| defaults = list([defaults]) | |
| defaults = [defaults] |
There was a problem hiding this comment.
Removed the if else statemement, because str.split() returns a list.
xl2times/utils.py
Outdated
| logger.warning( | ||
| f"Expected ANSWER-style defaults, got {invalid_defaults}" | ||
| ) | ||
| defaults = [default.split("=") for default in defaults] |
There was a problem hiding this comment.
Suggested change
| defaults = [default.split("=") for default in defaults] | |
| defaults = [default.split("=") for default in defaults if '=' in defaults] |
Perhaps we want to do this for the non invalid defaults?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pushes the NZ model above 95%.